Disabled backup allowed #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +37,6 @@ | |||
|
|
|||
| <application | |||
| android:name="kommunicate.io.sample.KommunicateApplication" | |||
| android:allowBackup="true" | |||
There was a problem hiding this comment.
@prateek-kommunicate Default value looks true, removing this should not help. Please make it false
https://developer.android.com/guide/topics/manifest/application-element#allowbackup
There was a problem hiding this comment.
Oh I see. I just checked that out more. Above Android 12 allowBackup false wont stop the device to device data transfers. So for that we have to add the data_extraction_rules which disables all the device to device transfers and cloud backups.
There was a problem hiding this comment.
Okay, as discussed please test it with the Sample SDK with reverse configurations.
adarshmishra
approved these changes
Aug 21, 2024
…ploads-Android-SDK
prateek-kommunicate
added a commit
that referenced
this pull request
Sep 24, 2024
* Disabled backup allowed * Marked allow backup to false --------- Co-authored-by: Prateek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed allowed backup. As suggested in Android VPAT report. We are not using this feature.