Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Improve" is a very generic term, so here it is broken down:
The last one is the main reason for this update. This was brought up in KhronosGroup/glTF-Sample-Models#391 , with some details described there. The animation data for the linear translations did not loop (i.e. they ended at a different place than where they started), and nearly all values (translations, rotations...) had been ... slightly odd numbers.
EDIT: The following is now obsolete. Apparently, the bug that caused the model to not be rendered in the sample viewer has been fixed - see KhronosGroup/glTF-Sample-Viewer#495
Now... merging this should be uncontroversial, but... ... the updated model does not render in the glTF-Sample-Viewer 😬I opened KhronosGroup/glTF-Sample-Viewer#495 to track this. Let's see how that plays out...