Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve InterpolationTest #26

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Sep 6, 2023

"Improve" is a very generic term, so here it is broken down:

  • it had a size of 33KB, now it has 18KB
  • it contained 10 materials, now it contains 2
  • it generated 14 'Infos' and 40 'Hints' (!) when validating, now it generates only 1 'Info' (about the non-power-of-2 image size)
  • it had some ... slightly odd, non-looping animations

The last one is the main reason for this update. This was brought up in KhronosGroup/glTF-Sample-Models#391 , with some details described there. The animation data for the linear translations did not loop (i.e. they ended at a different place than where they started), and nearly all values (translations, rotations...) had been ... slightly odd numbers.

EDIT: The following is now obsolete. Apparently, the bug that caused the model to not be rendered in the sample viewer has been fixed - see KhronosGroup/glTF-Sample-Viewer#495

Now... merging this should be uncontroversial, but... ... the updated model does not render in the glTF-Sample-Viewer 😬

I opened KhronosGroup/glTF-Sample-Viewer#495 to track this. Let's see how that plays out...

@javagl
Copy link
Contributor Author

javagl commented Nov 21, 2023

The scale animations in this sample originally interpolated between (0.5, 0.5, 0.5) and (1.0, 1.0, 1.0). The sample now has been updated so that the scale animations interpolate between (0.0, 0.0, 0.0) and (1.0, 1.0, 1.0).

The main purpose of this is that according to #77, a scale of (0,0,0) (with 'step' interpolation) is sometimes used to "completely hide" a mesh, and some viewer seemed to not handle this properly.

@DRx3D DRx3D merged commit f9e4f0e into KhronosGroup:main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants