Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified InterpolationTest is not rendered #495

Closed
javagl opened this issue Sep 6, 2023 · 4 comments
Closed

Modified InterpolationTest is not rendered #495

javagl opened this issue Sep 6, 2023 · 4 comments

Comments

@javagl
Copy link
Contributor

javagl commented Sep 6, 2023

The InterpolationTest sample asset had some issues, and I tried to fix them.

Attached is the ORIGINAL version of the asset, and the MODIFIED one:

InterpolationTest-issue.zip

The original can be rendered in the glTF-Sample-Viewer.

The modified one passes validation, renders in three.js, filament, hilo3d, babylon.js, playcanvas ... but the glTF-Sample-Viewer simply does not display anything.

@javagl
Copy link
Contributor Author

javagl commented Nov 21, 2023

I just did another test, and now, the modified one also seems to work.

I'd be curious what may have caused this issue, and what exactly was changed so that it works now. (Quickly looking at the commit logs and pinging the name that appears most frequently: Maybe @UX3D-kanzler has an idea?)

But in any case, it seems to be resolved, so I'd close this issue soon.

@javagl
Copy link
Contributor Author

javagl commented Nov 22, 2023

It might well be that this was caused by an error in the handling of interleaved data, which was fixed as of #496 , but I haven't analyzed it in detail yet.

@jim-ec
Copy link
Contributor

jim-ec commented Dec 14, 2023

As mentioned by @javagl, commit 8b64a62 fixes the issue. The problem was the previously, tangents would be generated from a potentially interleaved accessor which was assumed to be non-interleaved. Thus changing the accessor in the asset to an interleaved format exposed that issue. I am not sure yet why the viewer did not render the asset at all, however.

@javagl
Copy link
Contributor Author

javagl commented Dec 14, 2023

(The "task" to close this issue sunk down in my TODO list, because it was "not important"...).

Analyzing the exact reason is probably not worthwhile, given that the issue of interleaved accessors would have caused trouble anyhow, and it's resolved for now, so it's probably OK to close.

@javagl javagl closed this as completed Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants