Initial Chaka Monkey ROTank support #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2022
lpgagnon
force-pushed
the
rotanks-cmes-tank
branch
2 times, most recently
from
52ea97e to
f8724aa
Compare
lpgagnon
changed the title
lpgagnon
force-pushed
the
rotanks-cmes-tank
branch
from
f8724aa to
2d7f161
Compare
For reuse in other Compatibility/ tanks. Could probably be used by the atlas, katniss and generic tanks too
As a separate part, following reDirect's lead. Covers most tank models, one Core for each. A number of CMES tank parts are actually multiple models combined; could have used SUBMODELs to do the same, didn't.
lpgagnon
force-pushed
the
rotanks-cmes-tank
branch
from
2d7f161 to
5160e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a separate part, following reDirect's lead.
Covers most tank models, one Core for each.
A number of CMES tank parts are actually multiple models combined;
could have used SUBMODELs to do the same, didn't.
With some refactoring to avoid copy-pasting everything from
the reDirect part. Could probably be used by other parts
outside the Compatibility folder, presumably with some tweaking.
There's about 30 tank parts, evenly split between non-RO, ro-yes-but-rp1-no, rp1-nocost and fully configured. I've come around to Pap's way of thinking; adding things to ROTanks is the most effective way to get configs that are consistent with the rest.