Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package extensions to test_stale_deps docstring #203

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Add package extensions to test_stale_deps docstring #203

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a45451
Add package extensions to `test_stale_deps` docstring
lgoettgens Sep 28, 2023
7834b60
Add changelog
lgoettgens Sep 28, 2023
aaa50f1
Update src/stale_deps.jl
lgoettgens Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- The docstring for `test_stale_deps` explains the situation with package extensions. ([#203](https://github.com/JuliaTesting/Aqua.jl/pull/203))


## [0.7.3] - 2023-09-25

Expand Down
8 changes: 7 additions & 1 deletion src/stale_deps.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@ Test that `package` loads all dependencies listed in `Project.toml`.
Note that this does not imply that `package` loads the dependencies
directly, this can be achieved via transitivity as well.

!!! note "Known bug"
!!! note "Weak dependencies and extensions"

Due to the automatic loading of package extensions once all of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it's not that they can't have any stale dependencies, it's that we cannot check for them with Aqua.

As a side note, the dependencies of an extension (the using statements at the top) are a superset of its triggers (that are necessary for it to load) because they also include the dependencies of the parent package itself

their dependencies are loaded, a package extension can, by design,
not have any stale dependencies.
lgoettgens marked this conversation as resolved.
Show resolved Hide resolved

!!! warning "Known bug"

Currently, `Aqua.test_stale_deps` does not detect stale
dependencies when they are stdlib. This is considered a bug and
Expand Down