Add package extensions to test_stale_deps docstring
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
=======================================
Coverage 76.80% 76.80%
=======================================
Files 11 11
Lines 763 763
=======================================
Hits 586 586
Misses 177 177
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@gdalle Is this what you had in mind? |
gdalle
reviewed
Sep 28, 2023
| !!! note "Known bug" | ||
| !!! note "Weak dependencies and extensions" | ||
|
|
||
| Due to the automatic loading of package extensions once all of |
There was a problem hiding this comment.
For me it's not that they can't have any stale dependencies, it's that we cannot check for them with Aqua.
As a side note, the dependencies of an extension (the using statements at the top) are a superset of its triggers (that are necessary for it to load) because they also include the dependencies of the parent package itself
lgoettgens
commented
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #136 as proposed in #136 (comment).