Commit
- Loading branch information
There are no files selected for viewing
5 comments
on commit b20a755
There was a problem hiding this comment.
Registration pull request created: JuliaRegistries/General/24571
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v0.7.0 -m "<description of version>" b20a755177647e2f60baae2557e4118c5c343e28
git push origin v0.7.0
There was a problem hiding this comment.
@tlienart Why did you tag a breaking version? There don't appear to be any breaking changes since last release. This requires updating version bounds in all dependencies, which can be painful (e.g. GiovineItalia/Gadfly.jl#1499).
There was a problem hiding this comment.
@nalimilan apologies for the nuisance, since no one maintains this package afaik but that a number of packages depend on it I thought it was less risky to do a minor release with the recent addition of datasets + bump of CSV since the PR merge required marking some tests as broken #102.
Anyway I guess here the right route would have been to not merge the PR and leave things as they were. Again apologies for that.
There was a problem hiding this comment.
How did that PR end up being merged while not even passing CI? Marking these tests as broken is just a bandaid, and making a release with broken tests is far from ideal.
There was a problem hiding this comment.
it's just the list of dataset that's not been updated... I'll try to fix that myself.
@JuliaRegistrator register