Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding gamair data #102

Closed
IlanReinstein opened this issue Jul 15, 2020 · 2 comments · Fixed by #112
Closed

Adding gamair data #102

IlanReinstein opened this issue Jul 15, 2020 · 2 comments · Fixed by #112

Comments

@IlanReinstein
Copy link
Contributor

I would like to add the datasets from Simon Wood's book on GAM's using R.

I've already used Vincent's (Rdatasets) package to create documentation and have the files locally ready to add.

@IlanReinstein
Copy link
Contributor Author

Submitted PR #103

@tlienart
Copy link
Collaborator

Hello @IlanReinstein this is now merged (finally), though it breaks some test in terms of documented datasets:

@test_broken size(dfs_found, 1) == size(dfs_documented, 1)
@test_broken sort(dfs_documented[!, [:Package, :Dataset]]) == sort(dfs_found)

would you be willing to look into this?

(sorry I'm not a main maintainer so trying to figure things out along the way...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants