Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from METADATA to registrator #172

Merged
merged 4 commits into from
Jul 10, 2019
Merged

Conversation

kescobo
Copy link
Contributor

@kescobo kescobo commented Jun 21, 2019

With the new package registration system, REQUIRE is out and Project.toml is in.

This is an annoying but necessary task, so I thought I'd just do it. I used this script, and added a version (0.14.0, since I figured this warranted a major version bump).

Project.toml Outdated Show resolved Hide resolved
@nalimilan
Copy link
Member

0.14.0, since I figured this warranted a major version bump

Does it? I don't think so, as nothing changes at all for users (the registries already generated the Project.tool file automatically under the hood).

@alyst
Copy link
Member

alyst commented Jun 25, 2019

Before the new release, I would like to merge #168, which is a (small) API change warranting a major version bump.
BTW, @nalimilan could you please take a look at #168?

@kescobo
Copy link
Contributor Author

kescobo commented Jun 25, 2019

Fine by me either way. Let me know if you want me to change it or leave it alone :-)

@alyst
Copy link
Member

alyst commented Jul 10, 2019

I think the consensus now is that the next release will be 0.13.2.
@kescobo Could you please commit the suggested change and add version, so that I can merge the PR?

kescobo and others added 2 commits July 10, 2019 11:23
Co-Authored-By: Milan Bouchet-Valat <[email protected]>
@kescobo
Copy link
Contributor Author

kescobo commented Jul 10, 2019

@alyst All set!

@alyst
Copy link
Member

alyst commented Jul 10, 2019

@kescobo Thanks! Actually, I've never used Registrator before :) Should I add the comment @JuliaRegistrator register + release notes and then merge?

@JuliaRegistrator
Copy link

Pull request comments will not trigger Registrator as it is disabled. Please trying using a commit or issue comment.

@kescobo
Copy link
Contributor Author

kescobo commented Jul 10, 2019

@alyst Evidently not? 😆

I've only used BioJulia's registrator, but I did it in an issue after the PR was merged. Seems like it makes the most sense to do in in the PR once it's merged but ¯_(ツ)_/¯

@alyst
Copy link
Member

alyst commented Jul 10, 2019

Also I should be careful calling the registrator by name, since it doesn't understand the quotes. :)
I'll try commenting the head commit after merging the PR.

@alyst alyst merged commit 0a1c065 into JuliaStats:master Jul 10, 2019
@kescobo kescobo deleted the registrator branch March 24, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants