Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script to generate a project file #1133

Merged
merged 1 commit into from
Apr 9, 2019
Merged

script to generate a project file #1133

merged 1 commit into from
Apr 9, 2019

Conversation

StefanKarpinski
Copy link
Member

No description provided.

rschwarz added a commit to scipopt/SCIP.jl that referenced this pull request Apr 9, 2019
 - generated by script from JuliaLang/Pkg.jl#1133

project = Dict(
"name" => name,
"uuid" => uuid(name),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the package is in General, could one add a "version" field and set it to the most recently-registered version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. I really didn't want to have to look at the registry at all for this, but I guess...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a technical reason to avoid it, or something else?

Anyway, if your comment was meant to indicate that you intended to address this, it didn't seem to make it into the final version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I figured I'd do it in a separate PR. No reason to block merging this since it's an additional feature. This script is going to improve over time as people use it and provide feedback, which is another reason not to do all the project files at once. Better to get feedback incrementally as people register new versions.

@StefanKarpinski
Copy link
Member Author

bors r+

1 similar comment
@fredrikekre
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Apr 9, 2019
1133: script to generate a project file r=fredrikekre a=StefanKarpinski



Co-authored-by: Stefan Karpinski <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 9, 2019

@bors bors bot merged commit a8978e1 into master Apr 9, 2019
@bors bors bot deleted the sk/gen_project branch April 9, 2019 16:45
rschwarz added a commit to scipopt/SCIP.jl that referenced this pull request May 9, 2019
 - generated by script from JuliaLang/Pkg.jl#1133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants