Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for StatsBase to 0.34, (keep existing compat) #4738

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 2, 2023

This pull request changes the compat entry for the StatsBase package from 0.33 to 0.33, 0.34.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@daschw daschw force-pushed the compathelper/new_version/2023-05-02-00-12-16-623-03928651741 branch from 3e66954 to 817a50b Compare May 2, 2023 00:12
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (552328c) 90.33% compared to head (2661aa0) 90.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4738   +/-   ##
=======================================
  Coverage   90.33%   90.33%           
=======================================
  Files          40       40           
  Lines        8739     8739           
=======================================
  Hits         7894     7894           
  Misses        845      845           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeastyBlacksmith
Copy link
Member

needs JuliaImages/Images.jl#1025

@devmotion
Copy link
Contributor

Bump 🙂 Images 0.25.3 supports StatsBase 0.34.

BeastyBlacksmith and others added 12 commits May 25, 2023 09:43
* Fix bar plot vector attribute with missing values

* format

---------

Co-authored-by: Simon Christ <[email protected]>
* fill whole line

* adjust to PGFPlotsX v1.6

* Update src/backends/pgfplotsx.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* tests and migrate unitformat

* fix tests

* format

* fix tests

* adjust empty label case

* add imports

* add compat

* ditch 1.6

* Revert "ditch 1.6"

This reverts commit 1f0ce95.

* change imports

* fix ci config
@BeastyBlacksmith BeastyBlacksmith merged commit 0b3015d into master May 26, 2023
@BeastyBlacksmith BeastyBlacksmith deleted the compathelper/new_version/2023-05-02-00-12-16-623-03928651741 branch May 26, 2023 06:47
@devmotion
Copy link
Contributor

Could you please tag a release with this compat change? 🙂

@BeastyBlacksmith
Copy link
Member

Done

@devmotion
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants