CompatHelper: bump compat for StatsBase to 0.34, (keep existing compat) #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sethaxen
force-pushed
the
compathelper/new_version/2023-05-02-01-16-10-191-00646024051
branch
from
394defe to
f083929
Compare
|
Held back by Plots.jl compatibility. We need JuliaPlots/Plots.jl#4738 first. |
|
And now it's held back by Kronecker.jl: MichielStock/Kronecker.jl#122 . |
|
But Kronceker.jl also hasn't registered a version in ages. That's what's still missing, right? |
|
Yes, a new version needs to be tagged. I've asked for it to be tagged here: MichielStock/Kronecker.jl@6d45a66#commitcomment-115837315 . |
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
+ Coverage 98.90% 98.99% +0.08%
==========================================
Files 98 104 +6
Lines 9896 10102 +206
==========================================
+ Hits 9788 10000 +212
+ Misses 108 102 -6 see 57 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Yay, it finally works. I will merge this before tagging the next release. |
kellertuer
deleted the
compathelper/new_version/2023-05-02-01-16-10-191-00646024051
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
StatsBasepackage from0.32, 0.33to0.32, 0.33, 0.34.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.