Add constructor for ADLChargeDriftModel
#369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhagemann
commented
Jan 28, 2024
Comment on lines
165
to
168
| const defaultADLfile = joinpath(get_path_to_example_config_files(), "ADLChargeDriftModel/drift_velocity_config.yaml") | ||
| function ADLChargeDriftModel(configfilename::AbstractString = defaultADLfile; kwargs...) | ||
| ADLChargeDriftModel(parse_config_file(configfilename); kwargs...) | ||
| end |
There was a problem hiding this comment.
If no config file is provided, the default ADLChargeDriftModel parameters are loaded as basis.
Comment on lines
+61
to
+65
| @inline _parse_value(::Type{T}, x::Quantity, unit::Unitful.Units) where {T} = begin | ||
| if dimension(x) != dimension(unit) throw(ConfigFileError("The quantity '$(x)' cannot be converted to unit '$(unit)'")) end | ||
| T(to_internal_units(float(x))) | ||
| end | ||
| @inline _parse_value(::Type{T}, s::String, unit::Unitful.Units) where {T} = _parse_value(T, uparse(s), unit) |
There was a problem hiding this comment.
_parse_value now also checks whether the passed value has the correct dimensions and throws a ConfigFileError if it doesn't
Comment on lines
+153
to
+159
| @testset "Modify mobility parameters using keyword arguments" begin | ||
| cdm = ADLChargeDriftModel{Float64}(e100μ0 = 40000u"cm^2/(V*s)", e111μn = 5u"cm^2/(V*s)", h100β = 2, h111E0 = 50u"V/cm") | ||
| @test cdm.electrons.axis100.mu0 == 4.0 # internal unit is m^2/(V*s) | ||
| @test cdm.electrons.axis111.mun == 0.0005 # internal unit is m^2/(V*s) | ||
| @test cdm.holes.axis100.beta == 2.0 # no unit conversion | ||
| @test cdm.holes.axis111.E0 == 5000.0 # internal unit is V/m | ||
| end |
There was a problem hiding this comment.
Internally, the parameter values are stored in internal_units
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the convenience of the
ADLChargeDriftModelconstructor and closes #252.Previously, the
ADLChargeDriftModelwas always constructed from a config file. Now: