Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constructor method for ADLChargeDriftModel (and others) #252

Closed
lmh91 opened this issue Jan 24, 2022 · 0 comments · Fixed by #369
Closed

Add constructor method for ADLChargeDriftModel (and others) #252

lmh91 opened this issue Jan 24, 2022 · 0 comments · Fixed by #369
Labels
convenience Improve user-friendliness good first issue Good for newcomers

Comments

@lmh91
Copy link
Collaborator

lmh91 commented Jan 24, 2022

Right now the ADL charge drift model is usually constructed from a configuration file.

I think it would be nice to also have a constructor function for it,
which takes all the parameters, e100μ0 ..., as keyword arguments
(defaults would be the values from the ADL paper(s) which we can update once we have better ones).

The current method taking the configuration-file (dictionary) as input should than just pass the values to that keyword constructor method.

Same for the temperature model constructors.

@lmh91 lmh91 added good first issue Good for newcomers convenience Improve user-friendliness labels Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
convenience Improve user-friendliness good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant