-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SuiteSparse_jll] Update to v7.0.1 #48855
Conversation
SparseArrays.jl needs updates to use the new SuiteSparse as discussed in JuliaSparse/SparseArrays.jl#332. We shouldn't update before that is done, and we bump SparseArrays.jl here. |
@ViralBShah fix proposed at JuliaSparse/SparseArrays.jl#353 |
I've triggered the sparsearrays bump. Once that is in, we can upgrade the other pieces here. |
Indeed, will rebase after #48876 and JuliaPackaging/Yggdrasil#6296 are merged |
The SparseArrays bump PR is #48876 |
Now waiting on #48914 |
32bc566
to
d8fbba8
Compare
I have a hard time understanding where that
😢 see DrTimothyAldenDavis/SuiteSparse#308 It appears that these libraries are actually built on purpose, and their base version link against them. I do not see another choice than to actually link them into the build. |
Re. the CHOLMOD version warning. I welcome guidance here, because I really don't understand the update and testing process. I've opened an issue at JuliaSparse/SparseArrays.jl#359 because it appears it should be fixed there. But it's like I'm missing something, because a dependency update needs:
and steps 2 and 3 need to be possibly done multiple times because when SparseArrays.jl is updated, it doesn't fully test julia, so it needs to be iterated until new problems are discovered. |
Regarding unconditional loading of the CUDA SPQR this is somewhat annoying. It means we'll have to rename the actual CUDA binaries... |
It's picking up Hopefully going forward the steps 2 and 3 don't need to be repeated too many times now that we have updated the ambiguity detection tests. Perhaps your larger point is that this process needs to be documented. The hope is that we will be able to move SparseArrays.jl out of stdlibs in the next release, which will simplify things greatly. Because SuiteSparse is part of the stdlib, it gets pinned to the version that ships in Julia. So I believe to run the wrapper script, one has to run it as part of the PR that also bumps SuiteSparse in Julia. |
I have no idea how to do that. Can you point to instructions, or a previous PR?
I have looked at that, but it's a manual process in a different repo. I don't see how I can fit that into the julia PR. |
The process has to run in SparseArrays.jl, update the code there, and we run the bump script to pull the updated SparseArrays.jl into Julia master. Then we can rerun this one. I need to look into why this didn't get detected in SparseArrays.jl tests to begin with. |
What version(s) of SparseSuite is SparseArrays.jl tested against? If it is tied to that in julia, then that would be why, I suppose. |
Ok, so here's what is happening:
The two need to be tested together, which I'll try to do locally, and then push things. These are remnants of our recent efforts to remove SparseArrays from stdlib, and decouple SparseArrays.jl and SuiteSparse.jl (which didn't fully go through successfully). |
Carried forward in #48977 |
This will not work currently, as it requires merging of JuliaPackaging/Yggdrasil#6296 first
This is currently progressing through a full build from source on my machine