Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cholmod version is recorded somewhere in source? #359

Closed
fxcoudert opened this issue Mar 9, 2023 · 5 comments
Closed

Cholmod version is recorded somewhere in source? #359

fxcoudert opened this issue Mar 9, 2023 · 5 comments

Comments

@fxcoudert
Copy link
Contributor

SuiteSparse update in Julia in JuliaLang/julia#48855 is blocked because somehow an old cholmod version is recorded, apparently in this repo:

┌ Warning: CHOLMOD version incompatibility
  | │
  | │ Julia was compiled with CHOLMOD version 3.0.14. It is
  | │ currently linked with version 4.0.3.
  | │ This might cause Julia to terminate when working with
  | │ sparse matrix factorizations, e.g. solving systems of
  | │ equations with \.
  | │
  | │ It is recommended that you use Julia with the same major
  | │ version of CHOLMOD as the one used during the build, or
  | │ download the generic binaries from www.julialang.org,
  | │ which ship with the correct versions of all dependencies.
  | └ @ SparseArrays.CHOLMOD /cache/build/default-amdci5-7/julialang/juliamaster/usr/share/julia/stdlib/v1.10/SparseArrays/src/solvers/cholmod.jl:199

I do not understand what “Julia was compiled with CHOLMOD version 3.0.14” means. In the PR, it is absolutely wrong: Julia was compiled with version 4.0.3, the PR is updating that version.

The warning makes several test fail (output matching becomes wrong).

@ViralBShah
Copy link
Member

ViralBShah commented Mar 10, 2023

We need to update the SuiteSparse auto-generated wrappers in gen. The script doesn't run right now, because there seems to have been a change in the .h filenames and how they are organized.

julia> include("generator.jl")
  Downloaded artifact: SuiteSparse
ERROR: LoadError: AssertionError: isfile(cholmod_blas_h)

This was a change in SuiteSparse 6: https://github.com/DrTimothyAldenDavis/SuiteSparse/releases/tag/v6.0.0, and probably commenting it out in generator.jl should suffice. Trying it now.

@Gnimuc
Copy link
Member

Gnimuc commented Mar 22, 2023

@ViralBShah
Copy link
Member

Right - that needs updating of the wrappers. It is picking up the old ones.

@ViralBShah
Copy link
Member

I see, you updated them. So what we'll need to do is bump SparseArrays on Julia master as well (otherwise the nightly that is tested with here has the old SuiteSparse versions baked into the system image). So I would ignore the failing test here for the SuiteSparse bump - which is expected.

@ViralBShah
Copy link
Member

Being solved in #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants