Fix the stage and version-check targets for make -C deps
#47881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable `DEP_LIBS_STAGED` was removed in PR 40998 but it's still being referenced in other places. Notably, its removal renders `make -C deps stage` and `make -C deps version-check` as no-ops. For reference, the definition of the variable prior to 40998 was ```make DEP_LIBS_STAGED := $(filter-out libsuitesparse-wrapper,$(DEP_LIBS)) ``` Since that PR removed `libsuitesparse-wrapper` entirely, we can simply initialize `DEP_LIBS_STAGED` to `DEP_LIBS`.
ararslan
added
building
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
DEP_LIBS_STAGEDwas removed in #40998 but it's still being referenced in other places. Notably, its removal rendersmake -C deps stageandmake -C deps version-checkas no-ops. For reference, the definition of the variable prior to #40998 wasSince that PR removed
libsuitesparse-wrapperentirely, we can simply initializeDEP_LIBS_STAGEDtoDEP_LIBS.