-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SuiteSparse_wrapper and winclang patch #40998
Conversation
We'll adopt this change starting with SuiteSparse 5.10.1. This PR will be updated to use the newer version once we merge it in Yggdrasil: JuliaPackaging/Yggdrasil#3099 |
@Gnimuc When we want to use a newer version of SuiteSparse, do we need to make any changes to SuiteSparse.jl's auto-generated wrappers. IIRC, we do check for version numbers in the code - so that may be necessary. There really should be no changes between 5.8.1 and 5.10.1, but it gives us a clean new version to adopt in Julia 1.7, where we can stop shipping the wrappers. |
If the new version of |
I am just in the process of bumping it all, and just merged 5.10.1 into Yggdrasil. This way we can keep making new releases if we run into issues, without disrupting older Julia releases (1.6 and earlier). Most of the new work is in GraphBLAS, so I don't expect any problems. |
* Remove SuiteSparse_wrapper and winclang patch Fix https://github.com/JuliaLang/SuiteSparse.jl/issues/11 Fix https://github.com/JuliaLang/julia/issues/37322 * Update SuiteSparse version to 5.10.1 * Update libsuitesparse checksums for 5.10.1 * Remove more wrapper stuff
* Remove SuiteSparse_wrapper and winclang patch Fix https://github.com/JuliaLang/SuiteSparse.jl/issues/11 Fix https://github.com/JuliaLang/julia/issues/37322 * Update SuiteSparse version to 5.10.1 * Update libsuitesparse checksums for 5.10.1 * Remove more wrapper stuff
The variable `DEP_LIBS_STAGED` was removed in PR #40998 but it's still being referenced in other places. Notably, its removal renders `make -C deps stage` and `make -C deps version-check` as no-ops. For reference, the definition of the variable prior to #40998 was ```make DEP_LIBS_STAGED := $(filter-out libsuitesparse-wrapper,$(DEP_LIBS)) ``` Since that PR removed `libsuitesparse-wrapper` entirely, we can simply initialize `DEP_LIBS_STAGED` to `DEP_LIBS`.
Thanks to SuiteSparse.jl now in its own repo, we have been able to rapidly move and get rid of a bunch of old stuff.
Fix https://github.com/JuliaLang/SuiteSparse.jl/issues/11
Fix JuliaLang/LinearAlgebra.jl#764
This is all possible thanks to @Gnimuc!