Do not trigger write barrier when the child is a permanently rooted object #24304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuyichao
force-pushed
the
yyc/codegen/wb
branch
from
96e42da to
d2e679c
Compare
ararslan
reviewed
Oct 24, 2017
src/cgutils.cpp
Outdated
| #if JL_LLVM_VERSION >= 50000 | ||
| F->addParamAttr(A->getArgNo(), Attribute::NonNull); | ||
| #else | ||
| F->setAttributes(F->getAttributes().addParamAttribute(getContext(), A->getArgNo(), |
There was a problem hiding this comment.
Looks like this like is causing the failure on FreeBSD LLVM 3.9.
In file included from /usr/home/julia/worker/11rel-amd64/build/src/codegen.cpp:803:
./cgutils.cpp:352:59: error: use of undeclared identifier 'getContext'; did you mean 'getcontextx'?
F->setAttributes(F->getAttributes().addParamAttribute(getContext(), A->getArgNo(),
^~~~~~~~~~
getcontextx
/usr/include/ucontext.h:59:13: note: 'getcontextx' declared here
ucontext_t *getcontextx(void);
^
In file included from /usr/home/julia/worker/11rel-amd64/build/src/codegen.cpp:803:
./cgutils.cpp:352:41: error: no member named 'addParamAttribute' in 'llvm::AttributeSet'
F->setAttributes(F->getAttributes().addParamAttribute(getContext(), A->getArgNo(),
~~~~~~~~~~~~~~~~~~ ^
2 errors generated.
gmake[1]: *** [Makefile:138: codegen.dbg.obj] Error 1
dbba419 to
c8dc445
Compare
|
I'm also convienced that we should probably do this before LICM and loop vectorization and that'll probably mean at least partially spliting out the analysis code especially the ones for refinement. This should be good enough for now at least on 3.9 though. |
yuyichao
force-pushed
the
yyc/codegen/wb
branch
5 times, most recently
from
5b5cf3a to
f55b571
Compare
…bject Or when the parent and the child are the same object
yuyichao
force-pushed
the
yyc/codegen/wb
branch
from
f55b571 to
35079eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the simplest case in #22426 . A more generic version would require sorting the age of objects. At least now storing a
nothingwill never get a write barrier anymore.This is based on #24283 and #24108 .