A few cleanup/optimizations related to tag handling in codegen #24283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yuyichao
force-pushed
the
yyc/codegen/tag
branch
3 times, most recently
from
5dfdf48 to
06002c9
Compare
|
I can't find LLVM doc for how to deal with this but the solution seems wrong since it is explicitly documented that |
yuyichao
force-pushed
the
yyc/codegen/tag
branch
3 times, most recently
from
170bd44 to
e790bd4
Compare
yuyichao
force-pushed
the
yyc/codegen/tag
branch
4 times, most recently
from
99f48e9 to
eef4cff
Compare
|
... I should stop adding more stuff to this PR.... This is now ~5 PR's squashed into one.... |
yuyichao
force-pushed
the
yyc/codegen/tag
branch
3 times, most recently
from
357827d to
7b8a9b9
Compare
|
Review? Should I merge this as is or should I split things out a little? |
yuyichao
force-pushed
the
yyc/codegen/tag
branch
3 times, most recently
from
c1da47a to
aa8adc8
Compare
* Create `julia.typeof` and `julia.write_barrier` intrinsics So that tag access is easier for the llvm passes to handle. This also completely hides the tag access from LLVM before lowering of these intrinsics which makes it possible to mark the write barrier as `inaccessiblememonly` and enable store to load forwarding on mutable types. * Mark `jl_gc_queue_root` as `inaccessiblemem_or_argmemonly`. Should also have a positive impact on LLVM memory access optimizations. * In non-imaging mode, use the pointer literals directly for union type. * Remove old code that check whether the child is NULL before running the write barrier This is not needed anymore. * Mark functions returning julia object as `nonnull` return. This can avoid `NULL` check together with the improved store to load forwarding. * Remove `jlnewbits_func` which is not used in codegen anymore. * Fix `LateLowerGCFrame` initialization `runOnFunction` shouldn't modify the `Module`. * Add more `dereferencable` attributes and explicitly specify `nonnull` since it is not implied by `dereferencable` for non default addrspace. Also add range metadata on the tag load. The change should also make it easier to do more allocation optmization in LLVM for objects with object reference as fields.
yuyichao
force-pushed
the
yyc/codegen/tag
branch
from
aa8adc8 to
956f45b
Compare
|
Without corruption that should only cause segfault if the |
|
Previously the calls to this function were guarded by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
julia.typeofandjulia.write_barrierintrinsicsSo that tag access is easier for the llvm passes to handle.
This also completely hides the tag access from LLVM before lowering of these intrinsics
which makes it possible to mark the write barrier as
inaccessiblememonlyand enablestore to load forwarding on mutable types.
Mark
jl_gc_queue_rootasinaccessiblemem_or_argmemonly.Should also have a positive impact on LLVM memory access optimizations.
In non-imaging mode, use the pointer literals directly for union type.
Remove old code that check whether the child is NULL before running the write barrier
This is not needed anymore.
Mark functions returning julia object as
nonnullreturn.This can avoid
NULLcheck together with the improved store to load forwarding.Remove
jlnewbits_funcwhich is not used in codegen anymore.Fix
LateLowerGCFrameinitializationrunOnFunctionshouldn't modify theModule.The change should also make it easier to do more allocation optmization in LLVM for objects
with object reference as fields.