Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming (cont.) #16

Merged
merged 8 commits into from
Mar 9, 2020
Merged

Conversation

mforets
Copy link
Collaborator

@mforets mforets commented Mar 8, 2020

This is a continuation of #12, with the necessary changes such that the tests pass. In particular,

  • Added the method range(::AffineArithmetic) (which arguably can be used instead of interval, or the other way round),
  • Overloaded the functions eltype, zero and one for elements of type Affine.
  • Updated the project file with dependency upper bounds (useful for a future registration of this package).

Also, I saw that some of the range bounds improved, see the tests "Small powers and range".

@mforets
Copy link
Collaborator Author

mforets commented Mar 8, 2020

Regarding the example in #14, i get

julia> Affine(-1..1) + Affine(2020.0) + (Affine(1e23) - Affine(1e23))
affine=2020.0; [1.0]; [0, 0]⟩; range=[2019, 2021]

julia> Affine(-1..1) + Affine(2020.0) + Affine(1e23) - Affine(1e23)
affine=0.0; [1.0]; [0, 0]⟩; range=[0, 1]

Not sure why..

@dpsanders
Copy link
Member

Thanks a lot for doing this @mforets!

The reason it's still failing is that even with the changes in this PR, the method is still not actually rigorously bounding all errors. Basically we need to go through and make everything into an interval internally to do this.

In this example we are still seeing the usual problems with floating-point numbers that differ by too many orders of magnitude.

@dpsanders
Copy link
Member

I think we should just go ahead and merge this. Do you agree @mforets? If so, please feel free!

@mforets
Copy link
Collaborator Author

mforets commented Mar 9, 2020

Basically we need to go through and make everything into an interval internally to do this.

Got it. I agree to do this in a follow up PR; this one already contains many changes :)

I think we should just go ahead and merge this.

I don't have rights to merge, but i agree!

@dpsanders dpsanders merged commit 4d9c298 into JuliaIntervals:master Mar 9, 2020
@dpsanders
Copy link
Member

Thanks!

@mforets mforets deleted the mforets/renaming branch March 9, 2020 13:44
This was referenced Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants