Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming #12

Closed
wants to merge 7 commits into from
Closed

Renaming #12

wants to merge 7 commits into from

Conversation

dpsanders
Copy link
Member

@dpsanders dpsanders commented Jul 15, 2019

Rename:

  • Affine -> FullAffine (affine form with arbitrary number of "noise terms")
  • AFF -> Affine (the type to use, with a fixed number of noise terms and that keeps track of interval bounds, as in Rump 2015)
  • AF -> Aff (the internal affine form without interval bounds)

cc @mforets

@mforets
Copy link
Collaborator

mforets commented Dec 27, 2019

It's been a while since i don't use this package again, but seems to me that this PR is required now (AffineArithmetic#master doesn't compile in Julia v1.2 because of a dependency problem with Polynomials. The file AF1.jl is no longer included in this PR so that solves the problem).

The test files have to be revised though; the first failing test is

Construction from intervals: Error During Test at /home/mforets/.julia/dev/AffineArithmetic/test/runtests.jl:17
  Test threw exception
  Expression: Y_a == Affine(3.0, [0.0, 1.0])
  MethodError: no method matching Affine(::Float64, ::Array{Float64,1})
  Closest candidates are:
    Affine(!Matched::Interval{T}, ::Any, !Matched::Any) where T at /home/mforets/.julia/dev/AffineArithmetic/src/affine.jl:32
  Stacktrace:
   [1] top-level scope at /home/mforets/.julia/dev/AffineArithmetic/test/runtests.jl:17
   [2] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.2/Test/src/Test.jl:1113
   [3] top-level scope at /home/mforets/.julia/dev/AffineArithmetic/test/runtests.jl:11
   [4] top-level scope at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.2/Test/src/Test.jl:1113
   [5] top-level scope at /home/mforets/.julia/dev/AffineArithmetic/test/runtests.jl:9

@mforets
Copy link
Collaborator

mforets commented Mar 9, 2020

This PR can be closed 🚪

@dpsanders
Copy link
Member Author

Superseded by #16.

@dpsanders dpsanders closed this Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants