Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "close" method to the API #39

Merged
merged 1 commit into from
Dec 29, 2015
Merged

Conversation

EricForgy
Copy link

Note that since

close(w) = @dot w close

depends on @ dot, I moved api.jl to AtomShell so @ dot is defined first.

Closes #28

@pfitzseb
Copy link
Member

Wouldn't it make more sense to define close(w::Window) here, since all the other window managing methods are there as well?

It's a much smaller change then and the restructuring wouldn't be needed.

@EricForgy
Copy link
Author

That does make more sense. Thanks. I'll fix it.

@EricForgy
Copy link
Author

Maybe a rebase would be cleaner? (Still learning. Sorry.)

@pfitzseb
Copy link
Member

Hm, probably. Especially since close is defined twice now. :) You could also locally revert your commits, create a new one and force push that to this branch.
Also, I think you need to explicitly import it from Base in window.jl, since Base.close exists.

@EricForgy
Copy link
Author

I suck :D

Almost there :)

@EricForgy
Copy link
Author

So simple, huh? :) Thanks for your patience.

@pfitzseb
Copy link
Member

Also export it and I'll merge ;)

Edit: Oh wait, is that even necessary?! It isn't, right? If so, nevermind.

pfitzseb pushed a commit that referenced this pull request Dec 29, 2015
Add a "close" method to the API
@pfitzseb pfitzseb merged commit 23b6552 into JuliaGizmos:master Dec 29, 2015
@EricForgy EricForgy deleted the close branch December 29, 2015 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close a Window
2 participants