-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guide to my messy PRs #38
Comments
After #37, you can have a look at #35. My first commit on #35 already had the node.js side of #37, but I just stripped that out so #35 only has the blocking code changes. I think making the API synchronous is consistent with the rest of Blink.
|
I finished what @GlenHertz started in #21
|
Haha, no problem, having lots of PRs to deal with is one of the better problems I've had ;) Happy to answer any questions you have as well, it's really great to see people using / contributing to Blink.jl. |
Great, thanks! |
Hi @one-more-minute and @Varanas,
I'm sorry you get to suffer through my learning how to contribute to packages, but Blink happens to be potentially very useful to me so hopefully you can take that as a positive :)
Anyway, I'm afraid I made a mess, so I'll try to organize my PRs here. I'll update this as I go.
As a start, I think #37 is the easiest and, if you agree, can be merged first.
The text was updated successfully, but these errors were encountered: