Combined nightly fixes #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
force-pushed
the
ox/comb_nightlyfix
branch
3 times, most recently
from
01cc0d1 to
ae1c5e7
Compare
Also disables some of the heavily nested AD tests for now, since they are causing the segfault.
aviatesk
force-pushed
the
ox/comb_nightlyfix
branch
2 times, most recently
from
ae1c5e7 to
68082ff
Compare
aviatesk
force-pushed
the
ox/comb_nightlyfix
branch
from
68082ff to
496d032
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #127 +/- ##
==========================================
- Coverage 50.50% 48.06% -2.45%
==========================================
Files 27 27
Lines 2651 2657 +6
==========================================
- Hits 1339 1277 -62
- Misses 1312 1380 +68
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
I think we should revisit the hack I added, but yeah, let's keep our CI green for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines #125 and #126
(and is ontop of #123 that I merged earlier)