Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and clean sig on forward_diff_no_inf #121

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Conversation

oxinabox
Copy link
Member

I wanted to add a docstring as I had no idea what visit_custom! did.
And then i noticed that most of the other arguments are not used

@oxinabox oxinabox requested a review from Keno March 21, 2023 02:59
@oxinabox
Copy link
Member Author

Once CI is unbroken (#127 ) I will hopefully merge this.
But it doesn't seem pressing enough to merge without CI

@oxinabox oxinabox force-pushed the ox/forward_diff_no_inf branch from 055397c to cbeb7a8 Compare March 31, 2023 01:19
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 62.96% and project coverage change: -1.51 ⚠️

Comparison is base (5b3a846) 50.50% compared to head (0aee7b4) 49.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   50.50%   49.00%   -1.51%     
==========================================
  Files          27       27              
  Lines        2651     2661      +10     
==========================================
- Hits         1339     1304      -35     
- Misses       1312     1357      +45     
Impacted Files Coverage Δ
src/Diffractor.jl 100.00% <ø> (ø)
src/stage1/generated.jl 74.19% <ø> (+1.38%) ⬆️
src/stage1/recurse.jl 96.41% <ø> (+0.13%) ⬆️
src/stage1/recurse_fwd.jl 84.00% <ø> (-5.48%) ⬇️
src/stage1/termination.jl 45.45% <18.18%> (-13.64%) ⬇️
src/codegen/forward_demand.jl 29.29% <66.66%> (ø)
src/stage1/forward.jl 44.37% <100.00%> (-22.30%) ⬇️

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@oxinabox oxinabox merged commit 5998edd into main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants