resolve rrule ambiguities
#668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzgubic
commented
Aug 22, 2022
| @@ -54,15 +54,14 @@ | |||
| @non_differentiable invperm(::AbstractArray{Bool}) | |||
| @non_differentiable invpermute!(::Any, ::AbstractArray{Bool}) | |||
| @non_differentiable mapslices(::Any, ::AbstractArray{Bool}) | |||
| @non_differentiable Matrix(::AbstractArray{Bool}) | |||
There was a problem hiding this comment.
this is actually taken care of in https://github.com/JuliaDiff/ChainRules.jl/blob/main/src/rulesets/Base/array.jl#L15-L19
and the project to makes sure it is always NoTangent() for arrays of booleans, and it compiles away (at least the time is the same as with the dedicated rule)
mcabbott
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #654
And adds a test to prevent regressions in
rrule.There are still plenty ambiguities for
frulebecause their first arg when using@non_diffis sometimes::Any, which produces an ambiguity with the genericRuleConfigdispatch.