Merge pull request #668 from JuliaDiff/mz/ambiguities

resolve `rrule` ambiguities
JuliaDiff · Aug 22, 2022 · 595abfd · 595abfd · mzgubic · Aug 22, 2022
2 parents fef6aa8 + 6950027
commit 595abfd
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "ChainRules"
 uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
-version = "1.44.2"
+version = "1.44.3"
 
 [deps]
 Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"

diff --git a/src/rulesets/Base/nondiff.jl b/src/rulesets/Base/nondiff.jl
@@ -54,15 +54,14 @@
 @non_differentiable invperm(::AbstractArray{Bool})
 @non_differentiable invpermute!(::Any, ::AbstractArray{Bool})
 @non_differentiable mapslices(::Any, ::AbstractArray{Bool})
-@non_differentiable Matrix(::AbstractArray{Bool})
 @non_differentiable ndims(::AbstractArray{Bool})
 @non_differentiable parent(::AbstractArray{Bool})
 @non_differentiable parentindices(::AbstractArray{Bool})
 @non_differentiable permute!(::AbstractArray{Bool}, ::Any)
 @non_differentiable permutedims(::AbstractArray{Bool})
 @non_differentiable permutedims(::AbstractArray{Bool}, ::Any)
 @non_differentiable promote_shape(::AbstractArray{Bool}, ::Any)
-@non_differentiable repeat(::AbstractArray{Bool}, ::Any...)
+@non_differentiable repeat(::AbstractArray{Bool}, ::Integer...)
 @non_differentiable reshape(::AbstractArray{Bool}, ::Any...)
 @non_differentiable reverse(::AbstractArray{Bool}, ::Any...)
 @non_differentiable reverse!(::AbstractArray{Bool}, ::Any...)
@@ -174,9 +173,11 @@
 @non_differentiable findall(::AbstractArray)
 @non_differentiable findfirst(::Union{Regex, AbstractString, Function, AbstractChar}, ::AbstractString)
 @non_differentiable findfirst(::Function, ::Any)
+@non_differentiable findfirst(::Function, ::AbstractString)
 @non_differentiable findfirst(::AbstractArray)
 @non_differentiable findlast(::Union{AbstractString, Function, AbstractChar}, ::AbstractString)
 @non_differentiable findlast(::Function, ::Any)
+@non_differentiable findlast(::Function, ::AbstractString)
 @non_differentiable findlast(::AbstractArray)
 @non_differentiable first(::AbstractChar)
 @non_differentiable first(::Cmd)

diff --git a/test/rulesets/Base/array.jl b/test/rulesets/Base/array.jl
@@ -153,6 +153,8 @@ end
 
     @test rrule(repeat, [1,2,3], 4)[2](ones(12))[2] == [4,4,4]
     @test rrule(repeat, [1,2,3], outer=4)[2](ones(12))[2] == [4,4,4]
+
+    test_rrule(repeat, [true, false], 3)
 end
 
 @testset "hcat" begin

diff --git a/test/test_helpers.jl b/test/test_helpers.jl
@@ -220,4 +220,9 @@ ChainRulesCore.frule((_, Δx), ::typeof(flog), x::Number) = log(x), inv(x) * Δx
         test_frule(flog, 8.9 + im)    
     end
 
+    @testset "ambiguities" begin
+        @test [] == filter(Test.detect_ambiguities(ChainRules, ChainRulesCore)) do t
+            (t[1].name in [:rrule, Symbol("rrule##kw")])
+        end
+    end
 end