Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pullbacks only taking a single input #189

Merged
merged 3 commits into from
May 20, 2020
Merged

Switch to pullbacks only taking a single input #189

merged 3 commits into from
May 20, 2020

Conversation

oxinabox
Copy link
Member

@oxinabox oxinabox commented May 7, 2020

JuliaDiff/ChainRulesCore.jl#152

Needs to have Project.toml updated after ChainRulesCore and ChainRulesTestUtils PRs are merged.

Project.toml Outdated Show resolved Hide resolved
Copy link
Member

@willtebbutt willtebbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM provided that tests pass once the new version of ChainRulesTestUtils

@oxinabox oxinabox merged commit 54d1d74 into master May 20, 2020
@oxinabox oxinabox deleted the ox/1pb branch August 17, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants