Merge pull request #189 from JuliaDiff/ox/1pb

Switch to pullbacks only taking a single input
JuliaDiff · May 20, 2020 · 54d1d74 · 54d1d74 · oxinabox · May 20, 2020
2 parents 2d8b265 + 3fe9c7d
commit 54d1d74
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 14 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "ChainRules"
 uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
-version = "0.5.3"
+version = "0.6.0"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
@@ -10,8 +10,8 @@ Requires = "ae029012-a4dd-5104-9daa-d747884805df"
 Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
 
 [compat]
-ChainRulesCore = "0.7"
-ChainRulesTestUtils = "0.2.2"
+ChainRulesCore = "0.8"
+ChainRulesTestUtils = "0.3"
 Compat = "3"
 FiniteDifferences = "0.9"
 Reexport = "0.2"

diff --git a/src/rulesets/Base/base.jl b/src/rulesets/Base/base.jl
@@ -77,14 +77,3 @@ function rrule(::typeof(identity), x)
     end
     return (x, identity_pullback)
 end
-
-function rrule(::typeof(identity), x::Tuple)
-    # `identity(::Tuple)` returns multiple outputs;because that is how we think of
-    # returning a tuple, so its pullback needs to accept multiple inputs.
-    # `identity(::Tuple)` has one input, so its pullback should return 1 matching output
-    # see https://github.com/JuliaDiff/ChainRulesCore.jl/issues/152
-    function identity_pullback(ȳs...)
-        return (NO_FIELDS, Composite{typeof(x)}(ȳs...))
-    end
-    return x, identity_pullback
-end