Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For a 1.5 release #154

Merged
merged 2 commits into from
Jul 7, 2022
Merged

For a 1.5 release #154

merged 2 commits into from
Jul 7, 2022

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Jul 7, 2022

OkonSamuel and others added 2 commits July 8, 2022 09:42
@OkonSamuel @ablaom
add feature_importances stub (#148)
5dd0ef9 
* add intrinsic_importances stub and set fallback to
othing.

* fix error in intrinsic_importances docstring.

* rename intrinsic_importances method to eature_importances.

* remove fallback for eature_importances.

* Update src/model_api.jl

Co-authored-by: Anthony Blaom, PhD <[email protected]>
@ablaom
bump 1.5
58f4997
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2022 •
edited
Loading

Codecov Report

Merging #154 (58f4997) into master (f18bd47) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files           8        8           
  Lines         327      327           
=======================================
  Hits          291      291           
  Misses         36       36
Impacted Files Coverage Δ
src/MLJModelInterface.jl 100.00% <ø> (ø)
src/model_api.jl 70.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f18bd47...58f4997. Read the comment docs.

@ablaom ablaom merged commit e8da6ba into master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ablaom @codecov-commenter @OkonSamuel