add feature_importances stub
#148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
OkonSamuel
changed the title
intrinsic_importances stub feature_importances stub
ablaom
reviewed
Jul 7, 2022
ablaom
approved these changes
Jul 7, 2022
Codecov Report
@@ Coverage Diff @@
## dev #148 +/- ##
==========================================
+ Coverage 88.95% 88.99% +0.03%
==========================================
Files 8 8
Lines 326 327 +1
==========================================
+ Hits 290 291 +1
Misses 36 36
Continue to review full report at Codecov.
|
Merged
ablaom
added a commit
that referenced
this pull request
Jul 7, 2022
* add `feature_importances` stub (#148) * add intrinsic_importances stub and set fallback to othing. * fix error in intrinsic_importances docstring. * rename intrinsic_importances method to eature_importances. * remove fallback for eature_importances. * Update src/model_api.jl Co-authored-by: Anthony Blaom, PhD <[email protected]> * bump 1.5 Co-authored-by: Okon Samuel <[email protected]>
ablaom
added a commit
that referenced
this pull request
Jul 8, 2022
* add `feature_importances` stub (#148) * add intrinsic_importances stub and set fallback to othing. * fix error in intrinsic_importances docstring. * rename intrinsic_importances method to eature_importances. * remove fallback for eature_importances. * Update src/model_api.jl Co-authored-by: Anthony Blaom, PhD <[email protected]> * bump 1.5 * Update `metadata_model` to include traits for feature importances and training losses (#155) * + supports_training_losses,reports_feature_importances to model_metadata * bump 1.5.1 * bump StatisticalTraits = "3.1" Co-authored-by: Okon Samuel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
feature_importancesstub. Models which overload this method must also overload thereports_feature_importances` trait.Requires:
reports_feature_importancestrait. StatisticalTraits.jl#23Note
feature_importancesstub isn't exported in line with the goals set in this issue