Fix generalized inverse mass in velocity solve #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alized inverse mass
Jondolf
added
C-Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29.
The generalized inverse mass was being calculated based on the contact normal and not
delta_v, so it didn't take dynamic friction into account.In cases where the physics units used were larger, this caused explosive behaviour. Below is the
move_marblesexample, modified to use pixels instead of 3D units.Previously it exploded when moving the marbles:
2023-06-18.14-49-05.mp4
Now it works as expected:
2023-06-18.14-49-40.mp4