Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong generalized inverse masses in solve_vel #29

Closed
felixbjorkeson opened this issue Apr 30, 2023 · 2 comments · Fixed by #47
Closed

Wrong generalized inverse masses in solve_vel #29

felixbjorkeson opened this issue Apr 30, 2023 · 2 comments · Fixed by #47
Labels
C-Bug Something isn't working

Comments

@felixbjorkeson
Copy link
Contributor

I am pretty sure that the generalized inverse masses calculated in solve_vel should be based on the delta_v direction not the collision normal?

@Jondolf Jondolf added the C-Bug Something isn't working label May 1, 2023
@Jondolf
Copy link
Owner

Jondolf commented May 5, 2023

Thanks, I believe you're right. I probably just used the normal when I implemented restitution and forgot to change it to the delta_v direction when I added dynamic friction.

I'll fix this soon, probably as a part of fixing #2 if it ends up being related in any way.

@Jondolf
Copy link
Owner

Jondolf commented Jun 18, 2023

You were right, it's supposed to use the normalized delta_v. Just using normal causes explosive friction in many cases, as can be seen in #47. Thanks for spotting the issue and sorry for fixing it so late 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants