Improve binary expressions hanging #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seemed to be previously wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves formatting of hanging binary expressions:
Binary expressions are stored in the AST in a tree-like representation. Originally, we would always hang on the root node of this tree, even if doesn't necessarily need to happen (e.g. if we have already hung the LHS of this root node, and now the binop and RHS are under the column width).
This PR now takes the amount of space left on the line into account before hanging at the root node. This means we will no longer unnecessarily hang across multiple lines, which should make code less verbose and cleaner.
Also fixes #154 - leading comments to a binop are preserved, and leading comments of the RHS expression of a binop are moved to before the binop