Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang on equality operators #150

Closed
JohnnyMorganz opened this issue May 7, 2021 · 0 comments · Fixed by #163
Closed

Hang on equality operators #150

JohnnyMorganz opened this issue May 7, 2021 · 0 comments · Fixed by #163
Labels
enhancement New feature or request

Comments

@JohnnyMorganz
Copy link
Owner

Before the recent update to using shape, and the precedence improvements, we forced that binop expressions would not hang on equality operators, even when they go over the column width.
This was done mainly due to conditions in if statements, where hanging on equality operators looked weird.

This is no longer required anymore, since the recent improvements means that equality operators will look OK.
It also means we can hang to reduce line length in other places, because currently, StyLua will format like this:

assert(
	StringToHex(HexToString("05 e0 81 91 24 cb b2 2c 49 e2 0f 2e 8b 9a" .. " 47 56 9f fb fe ec d2 ff 1f")) == "05 e0 81 91 24 cb b2 2c 49 e2 0f 2e 8b 9a 47 56 9f fb fe ec d2 ff 1f"
)

(Source: https://raw.githubusercontent.com/SafeteeWoW/LibDeflate/4fd8e298c7315d47ee3cd2a9bc71e49f77f2afb0/tests/Test.lua)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant