Add js exports generation #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schahen
reviewed
Dec 19, 2023
skiko/build.gradle.kts
Outdated
| outputs.file(skikoTestMjs) | ||
| } | ||
|
|
||
| listOf(main, test).forEach { |
There was a problem hiding this comment.
Do we need this piece at all?
There was a problem hiding this comment.
I rebased on master, therefore this comment doesn't link anymore to the code.
This part is indeed needed:
KotlinCompilerPluginSupportPlugin has a method fun getPluginArtifact() which we override. We return SubpluginArtifact(SkikoArtifacts.groupId, IMPORT_GENERATOR) with null version. Therefore by default it tries to get the same version as koltin version.
Since our compiler plugin is not published, we need to substitute this implicit dependency.
There was a problem hiding this comment.
Also I moved it to buildSrc
Schahen
reviewed
Dec 19, 2023
skiko/build.gradle.kts
Outdated
| } | ||
|
|
||
| abstract class AbstractImportGeneratorCompilerPluginSupportPlugin( |
There was a problem hiding this comment.
it seems it might sense to keep this in buildSrc
Schahen
approved these changes
Dec 19, 2023
eymar
force-pushed
the
ok/js_exports_generation
branch
from
78fba00 to
23b3541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution was made by @ilgonmic ! Thank you Ilya!
Description:
To ensure that setup.mjs file contains correct exports, we better generate it than maintain manually.
It's done by a compiler plugin, which looks at WasmImport annotations and takes the name value from it.
P.S. our build.gradle.kts is quite big already (~1.8k lines). I tried to move new part to buildSrc, but I didn't manage to make work. I'll try to think about it separately.
UPD: a separate PR to split the build.gradle.kts into smaller parts - #845