Skip to content

Commit

Permalink
Race condition detected in tests jaegertracing#4340 (jaegertracing#4344)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
- Resolves jaegertracing#4340 

## Short description of the changes
- Server in test case was not closed

---------

Signed-off-by: ChillOrb <[email protected]>
  • Loading branch information
ChillOrb authored Mar 28, 2023
1 parent 13fa044 commit bc8e1d1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cmd/collector/app/server/http_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,7 @@ func TestStartHTTPServerParams(t *testing.T) {

server, err := StartHTTPServer(params)
require.NoError(t, err)
defer server.Close()
assert.Equal(t, 5*time.Minute, server.IdleTimeout)
assert.Equal(t, 6*time.Minute, server.ReadTimeout)
assert.Equal(t, 7*time.Second, server.ReadHeaderTimeout)
Expand Down

0 comments on commit bc8e1d1

Please sign in to comment.