Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race condition detected in tests #4340 #4344

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Conversation

ChillOrb
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Server in test case was not closed

@ChillOrb ChillOrb requested a review from a team as a code owner March 27, 2023 05:46
@ChillOrb ChillOrb requested a review from joe-elliott March 27, 2023 05:46
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (13fa044) 97.08% compared to head (db95e3c) 97.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4344      +/-   ##
==========================================
- Coverage   97.08%   97.08%   -0.01%     
==========================================
  Files         300      300              
  Lines       17697    17697              
==========================================
- Hits        17182    17181       -1     
- Misses        414      415       +1     
  Partials      101      101              
Flag Coverage Δ
unittests 97.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@yurishkuro yurishkuro merged commit bc8e1d1 into jaegertracing:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Race condition detected in tests
2 participants