Skip to content

Commit

Permalink
Pin Kafka to 3.1.0 to avoid CI job failure (jaegertracing#4421)
Browse files Browse the repository at this point in the history
Temporary workaround for jaegertracing#4420

---------

Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
yurishkuro authored Apr 27, 2023
1 parent 212b868 commit 48e1438
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
16 changes: 15 additions & 1 deletion .github/workflows/ci-kafka.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,31 @@ jobs:
- name: Run kafka integration tests
run: bash scripts/kafka-integration-test.sh

- name: Output Kafka logs
run: docker logs "${{ job.services.kafka.id }}"
if: ${{ failure() }}

services:
zookeeper:
image: bitnami/zookeeper
ports:
- 2181:2181
options: >-
--health-cmd "echo mntr | nc -w 2 -q 2 localhost 2181"
--health-interval 10s
--health-timeout 5s
--health-retries 5
env:
ALLOW_ANONYMOUS_LOGIN: yes
kafka:
image: bitnami/kafka
image: bitnami/kafka:3.1.0
ports:
- 9092:9092
options: >-
--health-cmd "kafka-broker-api-versions.sh --version"
--health-interval 10s
--health-timeout 5s
--health-retries 5
env:
KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://localhost:9092
ALLOW_PLAINTEXT_LISTENER: yes
Expand Down
2 changes: 1 addition & 1 deletion plugin/storage/integration/integration.go
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ func (s *StorageIntegration) waitForCondition(t *testing.T, predicate func(t *te
if predicate(t) {
return true
}
time.Sleep(100 * time.Millisecond) // Will wait up to 10 seconds at worst.
time.Sleep(time.Second) // Will wait at most 100 seconds.
}
return predicate(t)
}
Expand Down

0 comments on commit 48e1438

Please sign in to comment.