Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Kafka to 3.1.0 to avoid CI job failure #4421

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Apr 27, 2023

Temporary workaround for #4420

@yurishkuro yurishkuro requested a review from a team as a code owner April 27, 2023 02:46
@yurishkuro yurishkuro requested a review from joe-elliott April 27, 2023 02:46
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (212b868) 97.09% compared to head (1de0b86) 97.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4421      +/-   ##
==========================================
+ Coverage   97.09%   97.10%   +0.01%     
==========================================
  Files         300      300              
  Lines       17730    17730              
==========================================
+ Hits        17215    17217       +2     
+ Misses        414      413       -1     
+ Partials      101      100       -1     
Flag Coverage Δ
unittests 97.10% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plugin/storage/integration/integration.go 75.95% <0.00%> (-0.39%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro changed the title Display Kafka logs on CI job failure Pin Kafka to 3.1.0 to avoid CI job failure Apr 27, 2023
@yurishkuro yurishkuro merged commit 48e1438 into jaegertracing:main Apr 27, 2023
@yurishkuro yurishkuro deleted the fix-kafka branch April 27, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant