Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Imp conformance for GOV #4865

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Enable Imp conformance for GOV #4865

merged 1 commit into from
Feb 13, 2025

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jan 31, 2025

Description

This PR bumps the spec SRP to enable Imp conformance tests for GOV. I updated some of the translations and also got rid of some unused code in the GOV exec context.

This gets us closer to closing #4770

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/empty-withdrawals branch 4 times, most recently from dc7d197 to a0f811e Compare February 7, 2025 11:09
@Soupstraw Soupstraw force-pushed the jj/empty-withdrawals branch 3 times, most recently from a5ef4b6 to 73bbb47 Compare February 11, 2025 12:56
@Soupstraw Soupstraw marked this pull request as ready for review February 11, 2025 12:56
@Soupstraw Soupstraw requested a review from a team as a code owner February 11, 2025 12:56
@Soupstraw Soupstraw force-pushed the jj/empty-withdrawals branch 3 times, most recently from 6595262 to 7d71092 Compare February 11, 2025 13:51
@Soupstraw Soupstraw force-pushed the jj/empty-withdrawals branch 4 times, most recently from c071e39 to 9b519a0 Compare February 12, 2025 11:01
@Soupstraw Soupstraw changed the title Conformance bump: empty treasury withdrawals Enable Imp conformance for GOV Feb 12, 2025
@Soupstraw Soupstraw force-pushed the jj/empty-withdrawals branch 3 times, most recently from 8c14e96 to 2520afc Compare February 12, 2025 16:45
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Soupstraw Soupstraw force-pushed the jj/empty-withdrawals branch from 2520afc to e5c71de Compare February 13, 2025 11:41
@Soupstraw Soupstraw enabled auto-merge (rebase) February 13, 2025 11:42
@Soupstraw Soupstraw merged commit 36e0d6f into master Feb 13, 2025
153 of 157 checks passed
@Soupstraw Soupstraw deleted the jj/empty-withdrawals branch February 13, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants