Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrained generator for GOV generates invalid values #4886

Closed
Soupstraw opened this issue Feb 12, 2025 · 1 comment
Closed

Constrained generator for GOV generates invalid values #4886

Soupstraw opened this issue Feb 12, 2025 · 1 comment

Comments

@Soupstraw
Copy link
Contributor

Soupstraw commented Feb 12, 2025

I'm getting a conformance failure in #4865 in the GOV rule, because the EnactState from the ConwayGovExecContext is used in the GovState generator. The root of the problem is that we generate some "previous gov action IDs" in the EnactState that is part of the context, but these IDs don't make it to the proposals tree.

I think it'd be a good idea to move ledger-specific conformance code out of cardano-ledger-test before attempting to fix this.

@Soupstraw
Copy link
Contributor Author

I had accidentally removed some code that overwrites the enactState in the context with valid values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant