Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove era type parameter from MemoBytes #4844

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Remove era type parameter from MemoBytes #4844

merged 2 commits into from
Jan 22, 2025

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Jan 20, 2025

Description

MemoBytes type no long needs the era parameter, following the removal of crypto parameterization.
This PR is removing this type parameter from MemoBytes and making the necessary adjustments at the usage site.

Closes #4842

Checklist

  • Commits in meaningful sequence and with useful messages
  • Tests added or updated when needed
  • CHANGELOG.md files updated for packages with externally visible changes

    New section is never added with the code changes. (See RELEASING.md)
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary

    If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • Code formatted (use scripts/fourmolize.sh)
  • Cabal files formatted (use scripts/cabal-format.sh)
  • hie.yaml updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/no-era-memobytes branch from fa304e8 to 2dbb395 Compare January 21, 2025 00:56
@teodanciu teodanciu changed the title [wip] No-era MemoBytes Remove era type parameter from MemoBytes Jan 21, 2025
@teodanciu teodanciu marked this pull request as ready for review January 21, 2025 01:00
@teodanciu teodanciu requested a review from a team as a code owner January 21, 2025 01:00
@teodanciu teodanciu force-pushed the td/no-era-memobytes branch from 2dbb395 to aa2624e Compare January 21, 2025 11:43
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes me happy that we can finally make MemoBytes applicable to non-era parametric types!
There is a bit of simplification and few minor fixups that can be done in the PR, but other that that it looks great!

@teodanciu teodanciu force-pushed the td/no-era-memobytes branch from aa2624e to 3551f28 Compare January 22, 2025 16:32
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thank you!

And adjust usages accordingly
@teodanciu teodanciu force-pushed the td/no-era-memobytes branch from 3551f28 to 16023a3 Compare January 22, 2025 19:34
@lehins lehins enabled auto-merge January 22, 2025 19:39
@lehins lehins merged commit 562ee08 into master Jan 22, 2025
154 of 156 checks passed
@lehins lehins deleted the td/no-era-memobytes branch January 22, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove era type parameter from MemoBytes
2 participants