-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove era
type parameter from MemoBytes
#4844
Conversation
fa304e8
to
2dbb395
Compare
era
type parameter from MemoBytes
2dbb395
to
aa2624e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes me happy that we can finally make MemoBytes
applicable to non-era parametric types!
There is a bit of simplification and few minor fixups that can be done in the PR, but other that that it looks great!
libs/cardano-ledger-core/src/Cardano/Ledger/MemoBytes/Internal.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/MemoBytes/Internal.hs
Outdated
Show resolved
Hide resolved
aa2624e
to
3551f28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! Thank you!
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/Instances/Ledger.hs
Outdated
Show resolved
Hide resolved
And adjust usages accordingly
3551f28
to
16023a3
Compare
Description
MemoBytes
type no long needs theera
parameter, following the removal of crypto parameterization.This PR is removing this type parameter from
MemoBytes
and making the necessary adjustments at the usage site.Closes #4842
Checklist
CHANGELOG.md
files updated for packages with externally visible changesNew section is never added with the code changes. (See RELEASING.md)
.cabal
andCHANGELOG.md
files when necessary, according to theversioning process.
.cabal
files updated when necessaryIf you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
scripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
updated (usescripts/gen-hie.sh
)