Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(icon): update inputs and methods names #8781

Merged
merged 23 commits into from
Feb 3, 2021
Merged

chore(icon): update inputs and methods names #8781

merged 23 commits into from
Feb 3, 2021

Conversation

SisIvanova
Copy link
Collaborator

@SisIvanova SisIvanova commented Jan 12, 2021 •
edited by simeonoff
Loading

Closes #8769

Related to #8858

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@SisIvanova SisIvanova requested a review from simeonoff January 12, 2021 15:01
@SisIvanova SisIvanova marked this pull request as ready for review January 13, 2021 11:25
simeonoff
simeonoff requested changes Jan 14, 2021
View reviewed changes
@simeonoff simeonoff self-requested a review January 14, 2021 09:32
simeonoff
simeonoff previously approved these changes Jan 14, 2021
View reviewed changes
@simeonoff simeonoff added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jan 15, 2021
@simeonoff simeonoff self-requested a review January 15, 2021 08:37
@simeonoff simeonoff added ❌ status: awaiting-test PRs awaiting manual verification and removed 💥 status: in-test PRs currently being tested labels Jan 15, 2021
simeonoff
simeonoff previously approved these changes Jan 19, 2021
View reviewed changes
@simeonoff simeonoff self-requested a review January 28, 2021 08:44
@simeonoff simeonoff added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Feb 1, 2021
simeonoff
simeonoff previously approved these changes Feb 1, 2021
View reviewed changes
simeonoff
simeonoff previously approved these changes Feb 3, 2021
View reviewed changes
@simeonoff simeonoff merged commit 9c5811b into master Feb 3, 2021
@simeonoff simeonoff deleted the SIvanova/icon-inputs-names branch February 3, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simeonoff simeonoff simeonoff approved these changes

Assignees

@jackofdiamond5 jackofdiamond5

Labels
💥 status: in-test PRs currently being tested 🖼️ icon version: 11.1.x ❌ do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icon inputs should have same names in code and view files
3 participants
@SisIvanova @simeonoff @jackofdiamond5