Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon inputs should have same names in code and view files #8769

Closed
wnvko opened this issue Jan 11, 2021 · 2 comments · Fixed by #8781
Closed

Icon inputs should have same names in code and view files #8769

wnvko opened this issue Jan 11, 2021 · 2 comments · Fixed by #8781
Assignees
@simeonoff @SisIvanova
Labels
🖼️ icon program: igniteui project management 🧰 feature-request version: 11.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@wnvko
Copy link
Contributor

wnvko commented Jan 11, 2021 •
edited by simeonoff
Loading

Is your feature request related to a problem? Please describe.

The following igxIcon inputs have different names in code and in view files:

  • font vs fontSet
  • active vs isActive
  • innerColor vs color
  • iconName vs name

Describe the solution you'd like

All inputs should have same name in code and in view files. Otherwise using of the component is very confusing.
@simeonoff
Copy link
Collaborator

simeonoff commented Jan 11, 2021 •
edited
Loading

I would argue that neither font nor fontSet are correct. Color should not be set via javascript either imo. The rest I agree with.

What are code and view files?

@wnvko
Copy link
Contributor Author

wnvko commented Jan 11, 2021

For code I mean ts file and for view the html file.

@SisIvanova SisIvanova added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Jan 11, 2021
@SisIvanova SisIvanova mentioned this issue Jan 12, 2021
Merged
14 tasks
@SisIvanova SisIvanova added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Jan 14, 2021
@SisIvanova SisIvanova mentioned this issue Jan 14, 2021
Merged
16 tasks
@radomirchev radomirchev added the program: igniteui project management label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simeonoff simeonoff

@SisIvanova SisIvanova

Labels
🖼️ icon program: igniteui project management 🧰 feature-request version: 11.1.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(icon): update inputs and methods names IgniteUI/igniteui-angular
4 participants
@simeonoff @wnvko @radomirchev @SisIvanova