-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add row basic functionality #8093
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f523639
feat(addRow): Added sample, cell template and a pipe
mddragnev 613f766
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
mddragnev 3dcb294
feat(addRow): Add navigation handling and snackbar
mddragnev e2b8163
Merge branch 'master' into mdragnev/add-row-feat
mddragnev e977022
chore(*): fix failing tests
mddragnev 625ef4d
chore(*): resolve change requests and changes from spec doc
mddragnev 0f8b86f
chore(*): resolving change requests
mddragnev ed7f336
chore(*): Adding icons from the extended icons repo
mddragnev 9dc40e5
chore(*): fix failing build
mddragnev 08b595a
Merge branch 'master' into mdragnev/add-row-feat
ChronosSF 57860ee
Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular…
mddragnev 607a60c
chore(*): change snackbar showing logic and navigation scenario
mddragnev 6a4e762
chore(*): fix failing tests
mddragnev 350d851
chore(*): fix snackbar navigation and show cases
mddragnev 90798e4
chore(*): fix failing build
mddragnev abc1321
chore(*): subscribe only once to addrow snackbar action
mddragnev c14c8be
chore(*): fix failing tests
mddragnev 02cbd5b
Merge branch 'master' into mdragnev/add-row-feat
ChronosSF 5d76cd3
Merge branch 'master' into mdragnev/add-row-feat
ChronosSF c2cbfa4
Merge branch 'master' into mdragnev/add-row-feat
3phase 2f01d9b
chore(*): Add logic so that grid with MRL works as expected
mddragnev ead3eae
Merge branch 'mdragnev/add-row-feat' of https://github.com/IgniteUI/i…
mddragnev d6d202f
chore(*): fixing failing test and sass selector
mddragnev 0113d7f
chore(*): change snackbar class name selector name changed
mddragnev f2f3cb5
Merge branch 'master' into mdragnev/add-row-feat
ChronosSF File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-actions-base.directive.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 0 additions & 16 deletions
16
projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-pinning-actions-icons.ts
This file was deleted.
Oops, something went wrong.
10 changes: 5 additions & 5 deletions
10
...ts/igniteui-angular/src/lib/action-strip/grid-actions/grid-pinning-actions.component.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
<ng-container *ngIf="isRowContext"> | ||
<button *ngIf="inPinnedArea && pinnedTop" igxRipple igxButton="icon" (click)="scrollToRow($event)"> | ||
<igx-icon fontSet="pinning-actions-icons" name="jump_down"></igx-icon> | ||
<igx-icon fontSet="imx-icons" name="jump-down"></igx-icon> | ||
</button> | ||
<button *ngIf="inPinnedArea && !pinnedTop" igxRipple igxButton="icon" (click)="scrollToRow($event)"> | ||
<igx-icon fontSet="pinning-actions-icons" name="jump_up"></igx-icon> | ||
<igx-icon fontSet="imx-icons" name="jump-up"></igx-icon> | ||
</button> | ||
<button *ngIf="!pinned" igxRipple igxButton="icon" (click)="pin($event)"> | ||
<igx-icon fontSet="pinning-icons" name="pin"></igx-icon> | ||
<igx-icon fontSet="imx-icons" name="pin-left"></igx-icon> | ||
</button> | ||
<button *ngIf="pinned" igxRipple igxButton="icon" (click)="unpin($event)"> | ||
<igx-icon fontSet="pinning-icons" name="unpin"></igx-icon> | ||
<igx-icon fontSet="imx-icons" name="unpin-left"></igx-icon> | ||
</button> | ||
</ng-container> | ||
</ng-container> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property should be the interpolated version of the
$left
variable for RTL compatibility purposes.Also, are you sure you want to use percentages as the unit to set the position of the snackbar? If yes, how did you come up with those numbers?