Add row basic functionality #8093

mddragnev · 2020-09-04T12:13:00Z

Related to #5946 and IgniteUI/trial-watermark#50

Additional information (check all that apply):

Checklist:

All relevant tags have been applied to this PR
This PR includes unit tests covering all the new code (test guidelines)
This PR includes API docs for newly added methods/properties (api docs guidelines)
This PR includes feature/README.MD updates for the feature docs
This PR includes general feature table updates in the root README.MD
This PR includes CHANGELOG.MD updates for newly added functionality
This PR contains breaking changes
This PR includes ng update migrations for the breaking changes (migrations guidelines)
This PR includes behavioral changes and the feature specification has been updated with them

…into mdragnev/add-row-feat

projects/igniteui-angular/src/lib/grids/api.service.ts

projects/igniteui-angular/src/lib/grids/common/pipes.ts

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

projects/igniteui-angular/src/lib/grids/common/pipes.ts

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

projects/igniteui-angular/src/lib/grids/common/pipes.ts

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

projects/igniteui-angular/src/lib/grids/grid/grid.component.html

MayaKirova · 2020-09-10T15:05:10Z

projects/igniteui-angular/src/lib/grids/common/pipes.ts

+            recordRef: row,
+            addRow: true
+        };
+        collection.splice(parentRecordIndex + 1, 0, rec);


Since this pipe runs after all other pipes, there may be cases when the row should not be shown below the parent record index. For example, if you have a grid with master-detail views, if the new row is displayed under the parent (master row) it would visually break the hierarchy since the new row will appear above the details view:

In those cases it may be better to show the add row above it.
Also the add row should not allow expand/collapse operations

projects/igniteui-angular/src/lib/grids/common/pipes.ts

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

projects/igniteui-angular/src/lib/grids/grid/grid.component.html

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

MayaKirova · 2020-09-14T15:51:08Z

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

+            return;
+        }
+        if (commit) {
+            this.gridAPI.submit_add_value();


This seems to generate an update transaction. There's no need to generate an update transaction before adding the row.

…into mdragnev/add-row-feat

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts

3phase · 2020-09-23T12:46:37Z

When adding the Add Row functionality to the MRL template, you cannot edit the newly added rows in the row that appears beneath the click target of the action strip.

3phase · 2020-09-23T13:01:01Z

When adding a new row into a grid with enabled filtering, the grid is not added (the onRowAdded event won't be fired at all).

simeonoff · 2020-09-23T13:52:08Z

projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-theme.scss

+    %igx-grid__addrow-snackbar {
+        position: absolute;
+        z-index: 5;
+        left: 35%;


This property should be the interpolated version of the $left variable for RTL compatibility purposes.

Suggested change

left: 35%;

#{$left}: 35%;

Also, are you sure you want to use percentages as the unit to set the position of the snackbar? If yes, how did you come up with those numbers?

projects/igniteui-angular/src/lib/core/styles/components/grid/_grid-component.scss

…gniteui-angular into mdragnev/add-row-feat

mddragnev added 3 commits August 29, 2020 17:01

feat(addRow): Added sample, cell template and a pipe

f523639

Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …

613f766

…into mdragnev/add-row-feat

feat(addRow): Add navigation handling and snackbar

3dcb294

mddragnev assigned ChronosSF Sep 4, 2020

mddragnev and others added 2 commits September 9, 2020 14:57

Merge branch 'master' into mdragnev/add-row-feat

e2b8163

chore(*): fix failing tests

e977022

ChronosSF requested changes Sep 9, 2020

View reviewed changes

ChronosSF requested review from dkamburov and MayaKirova September 9, 2020 15:47

ChronosSF added 🛠️ status: in-development Issues and PRs with active development on them grid: row-adding grid: general version: 10.2.x labels Sep 9, 2020

ChronosSF marked this pull request as ready for review September 9, 2020 15:48

ChronosSF changed the title ~~Add row initial functionality~~ Add row basic functionality Sep 9, 2020

chore(*): resolve change requests and changes from spec doc

625ef4d

mddragnev requested a review from ChronosSF September 10, 2020 15:23

MayaKirova requested changes Sep 10, 2020

View reviewed changes

chore(*): resolving change requests

0f8b86f

mddragnev requested a review from MayaKirova September 11, 2020 12:00

mddragnev added 2 commits September 11, 2020 17:07

chore(*): Adding icons from the extended icons repo

ed7f336

chore(*): fix failing build

9dc40e5

ChronosSF previously approved these changes Sep 14, 2020

View reviewed changes

Merge branch 'master' into mdragnev/add-row-feat

08b595a

MayaKirova requested changes Sep 14, 2020

View reviewed changes

mddragnev added 2 commits September 17, 2020 11:28

Merge branch 'master' of https://github.com/IgniteUI/igniteui-angular …

57860ee

…into mdragnev/add-row-feat

chore(*): change snackbar showing logic and navigation scenario

607a60c

mddragnev dismissed ChronosSF’s stale review via 607a60c September 17, 2020 08:32

mddragnev requested review from MayaKirova and ChronosSF September 17, 2020 08:34

mddragnev requested a review from MayaKirova September 17, 2020 14:10

chore(*): fix failing build

90798e4

MayaKirova requested changes Sep 17, 2020

View reviewed changes

projects/igniteui-angular/src/lib/grids/grid-base.directive.ts Outdated Show resolved Hide resolved

chore(*): subscribe only once to addrow snackbar action

abc1321

mddragnev requested a review from MayaKirova September 18, 2020 07:38

chore(*): fix failing tests

c14c8be

MayaKirova previously approved these changes Sep 18, 2020

View reviewed changes

ChronosSF added 2 commits September 21, 2020 10:23

Merge branch 'master' into mdragnev/add-row-feat

02cbd5b

Merge branch 'master' into mdragnev/add-row-feat

5d76cd3

3phase self-assigned this Sep 21, 2020

ChronosSF added 💥 status: in-test PRs currently being tested and removed 🛠️ status: in-development Issues and PRs with active development on them labels Sep 23, 2020

ChronosSF requested a review from simeonoff September 23, 2020 11:54

Merge branch 'master' into mdragnev/add-row-feat

c2cbfa4

simeonoff requested changes Sep 23, 2020

View reviewed changes

mddragnev added 2 commits September 23, 2020 18:11

chore(*): Add logic so that grid with MRL works as expected

2f01d9b

Merge branch 'mdragnev/add-row-feat' of https://github.com/IgniteUI/i…

ead3eae

…gniteui-angular into mdragnev/add-row-feat

mddragnev dismissed MayaKirova’s stale review via ead3eae September 23, 2020 15:12

mddragnev and others added 3 commits September 24, 2020 17:05

chore(*): fixing failing test and sass selector

d6d202f

chore(*): change snackbar class name selector name changed

0113d7f

Merge branch 'master' into mdragnev/add-row-feat

f2f3cb5

ChronosSF requested review from simeonoff and MayaKirova September 24, 2020 14:23

ChronosSF approved these changes Sep 24, 2020

View reviewed changes

ChronosSF added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Sep 25, 2020

ChronosSF merged commit 203bc7a into master Sep 25, 2020

ChronosSF deleted the mdragnev/add-row-feat branch September 25, 2020 08:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add row basic functionality #8093

Add row basic functionality #8093

mddragnev commented Sep 4, 2020 •

edited

Loading

MayaKirova Sep 10, 2020

MayaKirova Sep 14, 2020

3phase commented Sep 23, 2020 •

edited

Loading

3phase commented Sep 23, 2020

simeonoff Sep 23, 2020

Add row basic functionality #8093

Add row basic functionality #8093

Conversation

mddragnev commented Sep 4, 2020 • edited Loading

Additional information (check all that apply):

Checklist:

MayaKirova Sep 10, 2020

Choose a reason for hiding this comment

MayaKirova Sep 14, 2020

Choose a reason for hiding this comment

3phase commented Sep 23, 2020 • edited Loading

3phase commented Sep 23, 2020

simeonoff Sep 23, 2020

Choose a reason for hiding this comment

mddragnev commented Sep 4, 2020 •

edited

Loading

3phase commented Sep 23, 2020 •

edited

Loading