Review and remove deprecated properties and events from the grids

CHANGELOG.md

@@ -1,6 +1,29 @@
 # Ignite UI for Angular Change Log
 
 All notable changes for each version of this project will be documented in this file.
+## 16.0.0
+- `IgxGrid`, `IgxTreeGrid`, `IgxHierarchicalGrid`
+  - **Breaking Changes**
+    The following deprecated grid properties in version 12.1.0 are now removed:
+        - *evenRowCSS*;
+        - *oddRowCSS*;
+        - *page*;
+        - *paging*;
+        - *perPage*;
+        - *totalPages*;
+        - *isFirstPage*;
+        - *isLastPage*;
+        - *pageChange*;
+    Also the following deprecated grid events are removed.
+        - *perPageChange*;
+        - *pagingDone*;
+    Deprecated methods removed from the grid API are:
+        - *nextPage*;
+        - *previousPage*;
+        - *paginate*;
+        - *getCellByColumnVisibleIndex*;
+ - **Breaking Changes** In the `IgxAddRowParent`, `IRowToggleEventArgs`, `IPinRowEventArgs` and `IPathSegment` interfaces the *rowID* property has been deprecated and a *key* property has been introduced instead;
+ - **Breaking Changes** In the `IGridEditDoneEventArgs` interface *rowID* and *rowData* properties are deprecated and new *data* property has been introduced.
 
 ## 16.0.0
 

projects/igniteui-angular/src/lib/action-strip/grid-actions/grid-editing-actions.component.spec.ts

@@ -203,6 +203,7 @@ describe('igxGridEditingActions #grid ', () => {
             expect(grid.rowPinning.emit).toHaveBeenCalledTimes(1);
             expect(grid.rowPinning.emit).toHaveBeenCalledWith({
                 rowID : row.key,
+                key: row.key,
                 insertAtIndex: 0,
                 isPinned: true,
                 row,
@@ -220,6 +221,7 @@ describe('igxGridEditingActions #grid ', () => {
             expect(grid.rowPinning.emit).toHaveBeenCalledTimes(2);
             expect(grid.rowPinning.emit).toHaveBeenCalledWith({
                 rowID : row5.key,
+                key: row5.key,
                 insertAtIndex: 1,
                 isPinned: true,
                 row: row5,
@@ -360,6 +362,7 @@ describe('igxGridEditingActions #grid ', () => {
                 primaryKey: row.key,
                 cancel: false,
                 rowData: treeGrid.getRowData(row.key),
+                data: treeGrid.getRowData(row.key),
                 oldValue: null,
                 owner: treeGrid
             };

projects/igniteui-angular/src/lib/grids/README.md

@@ -169,9 +169,6 @@ Below is the list of all inputs that the developers may set to configure the gri
 |`autoGenerateExclude`|Array|A list of property keys to be excluded from the generated column collection, default is _[]_|
 |`batchEditing`|boolean|Toggles batch editing in the grid, default is _false_|
 |`moving`|boolean|Enables the columns moving feature. Defaults to _false_|
-|`paging`|boolean|Enables the paging feature. Defaults to _false_.|
-|`page`| number | The current page index.|
-|`perPage`|number|Visible items per page, default is 15|
 |`allowFiltering`| boolean | Enables quick filtering functionality in the grid. |
 |`allowAdvancedFiltering`| boolean | Enables advanced filtering functionality in the grid. |
 |`filterMode`| `FilterMode` | Determines the filter mode, default value is `quickFilter`.|
@@ -184,8 +181,6 @@ Below is the list of all inputs that the developers may set to configure the gri
 |`rowSelectable`|boolean|Enables multiple row selection, default is _false_.|
 |`height`|string|The height of the grid element. You can pass values such as `1000px`, `75%`, etc.|
 |`width`|string|The width of the grid element. You can pass values such as `1000px`, `75%`, etc.|
-|`evenRowCSS`|string|Additional styling classes applied to all even rows in the grid.|
-|`oddRowCSS`|string|Additional styling classes applied to all odd rows in the grid.|
 |`paginationTemplate`|TemplateRef|You can provide a custom `ng-template` for the pagination part of the grid.|
 |`groupStrategy`| IGridGroupingStrategy | Provides custom group strategy to be used when grouping |
 |`groupingExpressions`| Array | The group by state of the grid.
@@ -237,7 +232,6 @@ A list of the events emitted by the **igx-grid**:
 |`columnInit`|Emitted when the grid columns are initialized. Returns the column object.|
 |`sortingDone`|Emitted when sorting is performed through the UI. Returns the sorting expression.|
 |`filteringDone`|Emitted when filtering is performed through the UI. Returns the filtering expressions tree of the column for which the filtering was performed.|
-|`pagingDone`|Emitted when paging is performed. Returns an object consisting of the previous and the new page.|
 |`rowAdded`|Emitted when a row is being added to the grid through the API. Returns the data for the new row object.|
 |`rowDeleted`|Emitted when a row is deleted through the grid API. Returns the row object being removed.|
 |`dataPreLoad`| Emitted when a new chunk of data is loaded from virtualization. |
@@ -287,9 +281,6 @@ Here is a list of all public methods exposed by **igx-grid**:
 |`enableSummaries(expressions: Array)`|Enable summaries for the columns and apply your `customSummary` if it is provided.|
 |`disableSummaries(fieldName: string)`|Disable summaries for the specified column.|
 |`disableSummaries(columns: string[])`|Disable summaries for the listed columns.|
-|`previousPage()`|Goes to the previous page if paging is enabled and the current page is not the first.|
-|`nextPage()`|Goes to the next page if paging is enabled and current page is not the last.|
-|`paginate(page: number)`|Goes to the specified page if paging is enabled. Page indices are 0 based.|
 |`markForCheck()`|Manually triggers a change detection cycle for the grid and its children.|
 |`pinColumn(name: string): boolean`|Pins a column by field name. Returns whether the operation is successful.|
 |`unpinColumn(name: string): boolean`|Unpins a column by field name. Returns whether the operation is successful.|

projects/igniteui-angular/src/lib/grids/api.service.ts

@@ -6,7 +6,7 @@ import { IFilteringExpressionsTree } from '../data-operations/filtering-expressi
 import { Transaction, TransactionType, State } from '../services/transaction/transaction';
 import { IgxCell, IgxGridCRUDService, IgxEditRow } from './common/crud.service';
 import { CellType, ColumnType, GridServiceType, GridType, RowType } from './common/grid.interface';
-import { IGridEditEventArgs, IPinRowEventArgs, IRowToggleEventArgs } from './common/events';
+import { ICellEditEventArgs, IPinRowEventArgs, IRowToggleEventArgs } from './common/events';
 import { IgxColumnMovingService } from './moving/moving.service';
 import { IGroupingExpression } from '../data-operations/grouping-expression.interface';
 import { ISortingExpression, SortingDirection } from '../data-operations/sorting-strategy';
@@ -137,13 +137,14 @@ export class GridBaseAPIService<T extends GridType> implements GridServiceType {
         }
     }
 
-    public update_cell(cell: IgxCell): IGridEditEventArgs {
+    public update_cell(cell: IgxCell): ICellEditEventArgs {
         if (!cell) {
             return;
         }
-        const args = cell.createEditEventArgs(true);
-
-        this.grid.summaryService.clearSummaryCache(args);
+        const args = cell.createCellEditEventArgs(true);
+        if (!this.grid.crudService.row) {
+            this.grid.summaryService.clearSummaryCache(args);
+        }
         const data = this.getRowData(cell.id.rowID);
         const newRowData = reverseMapper(cell.column.field, args.newValue);
         this.updateData(this.grid, cell.id.rowID, data, cell.rowData, newRowData);
@@ -187,7 +188,7 @@ export class GridBaseAPIService<T extends GridType> implements GridServiceType {
         const hasSummarized = grid.hasSummarizedColumns;
         this.crudService.updateRowEditData(row, value);
 
-        const args = row.createEditEventArgs(true, event);
+        const args = row.createRowEditEventArgs(true, event);
 
         // If no valid row is found
         if (index === -1) {
@@ -424,7 +425,7 @@ export class GridBaseAPIService<T extends GridType> implements GridServiceType {
         }
 
         const args: IRowToggleEventArgs = {
-            rowID,
+            rowID, key: rowID,
             expanded,
             event,
             cancel: false
@@ -585,7 +586,7 @@ export class GridBaseAPIService<T extends GridType> implements GridServiceType {
     public get_pin_row_event_args(rowID: any, index?: number, row?: RowType, pinned?: boolean) {
         const eventArgs: IPinRowEventArgs = {
             isPinned: pinned ? true : false,
-            rowID,
+            rowID, key: rowID,
             row,
             cancel: false
         }