Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and remove deprecated properties and events from the grids #12832

Closed
wants to merge 34 commits into from
Closed

Review and remove deprecated properties and events from the grids #12832

wants to merge 34 commits into from

Conversation

ddincheva
Copy link
Contributor

@ddincheva ddincheva commented Mar 30, 2023 •
edited by hanastasov
Loading

Closes #10617

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ddincheva ddincheva added the 🛠️ status: in-development Issues and PRs with active development on them label Mar 30, 2023
@ddincheva ddincheva self-assigned this Mar 30, 2023
ddincheva added 11 commits March 31, 2023 09:24
@ddincheva ddincheva marked this pull request as ready for review April 4, 2023 14:44
@ddincheva ddincheva requested a review from hanastasov April 4, 2023 14:44
@ddincheva ddincheva added ❌ status: awaiting-test PRs awaiting manual verification refactoring grid: paging grid version: 16.0.x and removed 🛠️ status: in-development Issues and PRs with active development on them labels Apr 4, 2023
@hanastasov hanastasov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Apr 7, 2023
@hanastasov hanastasov added 🛠️ status: in-development Issues and PRs with active development on them and removed 💥 status: in-test PRs currently being tested labels May 10, 2023
hanastasov
hanastasov reviewed May 12, 2023
View reviewed changes
projects/igniteui-angular/src/lib/grids/common/grid.interface.ts
@@ -552,19 +552,19 @@ export interface GridType extends IGridDataBindable {
columnVisibilityChanged: EventEmitter<IColumnVisibilityChangedEventArgs>;
batchEditingChange?: EventEmitter<boolean>;
densityChanged: EventEmitter<IDensityChangedEventArgs>;
rowAdd: EventEmitter<IGridEditEventArgs>;
rowAdd: EventEmitter<IRowDataEventArgs>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for customer, as IRowDataEventArgs does not overlap with IGridEditEventArgs. Maybe we dont want to expose yet another breaking chang,e, but since this PR contains breaking changes, I would like to get this arranged

damyanpetev pushed a commit that referenced this pull request May 12, 2023
@hanastasov @ddincheva
refactor(grids): remove deprecated props, fix tests and samples (#13004)
7ff88a2 
Isolated changes from #12832

Co-authored-by: Desislava Dincheva <[email protected]>
@ChronosSF ChronosSF changed the base branch from master to 16.0.x May 15, 2023 16:14
@github-actions
Copy link

There has been no recent activity and this PR has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jul 15, 2023
@radomirchev radomirchev removed the status: inactive Used to stale issues and pull requests label Jul 17, 2023
@radomirchev
Copy link
Contributor

@hanastasov what is the status of the PR?

@hanastasov
Copy link
Contributor

@hanastasov what is the status of the PR?

No one worked on this since releasing version 16. I can plan it for the upcoming sprint.

@radomirchev
Copy link
Contributor

@hanastasov it was not discussed at the planning meeting, though you can work on this only if you have the availability. The priority remains low.

@kdinev
Copy link
Member

kdinev commented Aug 24, 2023

@hanastasov @ddincheva Let's revive this for 16.1.x

@ddincheva
Copy link
Contributor Author

ddincheva commented Aug 31, 2023 •
edited
Loading

ALl the changes related to the removal of the deprecated grid properties have been already merged with this PR: #13004 and the changelog has been updated with the following PR #13005

@kdinev
Copy link
Member

kdinev commented Aug 31, 2023

@ddincheva Then let's close this PR :)

@ddincheva
Copy link
Contributor Author

Closing this PR because the rest of the necessary changes related to the deprecated properties of the event's arguments will be introduced directly in version 16.1.0 with this PR #13427

@ddincheva ddincheva closed this Aug 31, 2023
@ChronosSF ChronosSF deleted the ddincheva/deprecatedPropRemoval branch June 7, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanastasov hanastasov hanastasov left review comments

Assignees

@ddincheva ddincheva

Labels
grid 🛠️ status: in-development Issues and PRs with active development on them refactoring version: 16.0.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate rowID and rowData in interfaces
6 participants
@ddincheva @hanastasov @radomirchev @kdinev @ChronosSF @zdrawku